Unify flag handling#504
Conversation
…to handle flags and path-flags.
…ler flags to support path-specific flags. Compute the hast as crc of the combined string (and not by adding three crc for three strings).
Joerg Henrichs (hiker)
added
enhancement
… used for ignore lists when converting DEPENDS dependencies to file dependencies.
Sam Clarke-Green (t00sa)
left a comment
Sam Clarke-Green (t00sa)
left a comment
There was a problem hiding this comment.
This makes a lot more sense now that I've been through UM #57. I've added a couple of suggestions inline. I leave it up to you whether you want to accept the suggestion of the automatic code quality tool or not!
|
Thanks for the review, Sam Clarke-Green (@t00sa). I've addressed the issues, and brought the PR up to current main. Back to you. |
I am glad to hear that - I was hoping that this will be the case, that once you start using/modifying a build script, things fall into place! |
Sam Clarke-Green (t00sa)
left a comment
Sam Clarke-Green (t00sa)
left a comment
There was a problem hiding this comment.
Looks sensible to me. Unit tests pass successfully and we've used the same code in the UM testing branch. Approved.
Sam Clarke-Green (t00sa)
left a comment
Sam Clarke-Green (t00sa)
left a comment
There was a problem hiding this comment.
Reapproving
|
Changing and reverting the name of the PR has fixed the WIP bot problem! |
3 participants
This is getting reasonable stable,
but it's currently blocked by #502 (which I need for kernel extraction in gungho). I will also verify that this works as expected with the UM.